[PERF] Reorder urllib and remove --force-reinstall but keep pinned version #86128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis moves the urllib install to be the last thing to be pip installed in the series that caused the urllib failure and removes the forced reinstall of packages. This change will fix the iOS runs which have been failing due to forced-reinstalls causing the urllib package to update.
|
Member
Author
|
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2178693&view=results has a decent mix of setups succeeding with only single partition failures. This also does not change any non-performance pipeline tests so runtime failures are unrelated. |
cincuranet
approved these changes
May 12, 2023
LoopedBard3
added a commit
to LoopedBard3/runtime
that referenced
this pull request
Jun 7, 2023
…rsion (dotnet#86128) * Move scenario urllib imports to the last install position. * Remove force-reinstall from all pip installs in the scenarios-job.yml files.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the urllib install to be the last thing to be pip installed in the series that caused the urllib failure and removes the forced reinstall of packages. This change will fix the iOS runs which have been failing due to forced-reinstalls causing the urllib package to update.